Hide user field in api front-end and set default #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit mirrors the commit a18b641 by @bbelderbos which fixes this issue in days/053-056.
This commit is mirroring ab86ca9 in days/053-056. Previously, the registration form would not show any field errors that might occur during registration. This commit updates the `registration_form.html` template in the demo as well as the starter code to show occurring field errors.
Before, it was possible in the api font-end for a logged-in user to set the user value of a quote during create or update. This means, the user could set another user as the owner of the quote. This behavior seems unintended. To prevent this option, the user field is defined as a hidden field in the serializer. Hidden fields will not show up in the api frontend form. A quote should have a user assigned to it (even if it is not required on the model level) to allow management (update/delete) of the quote. The quote can only be managed by it's owner. To prevent quotes without an owner, the hidden user field is assigned the default value of the currently logged-in user in the serializer.
Member
|
Hi guys. Thank you @tbrlpld. @bbelderbos this one looks good to me. You OK with me merging it? |
Collaborator
|
@mikeckennedy yep all good, forgot to merge it in. @tbrlpld great enhancement, I like your explanatory comment and also that you ported the template fix from the other PR into this project, thanks a lot! |
Member
|
Thanks! :) |
Contributor
Author
|
Happy to help! 😊
Thank you guys for the course @mkennedy @bbelderbos
… On Jan 4, 2020, at 13:04, Michael Kennedy ***@***.***> wrote:
Thanks! :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, it was possible in the api font-end for a logged-in user to set the user value of a quote during create or update. This means, the user could set another user as the owner of the quote.
This behavior seems unintended.
To prevent this option, the user field is defined as a hidden field in the serializer. Hidden fields will not show up in the api frontend form.
A quote should have a user assigned to it (even if it is not required on the model level) to allow management (update/delete) of the quote. The quote can only be managed by it's owner. To prevent quotes without an owner, the hidden user field is assigned the default value of the currently logged-in user in the serializer.
This change was previously discussed with @bbelderbos via email.
Other commits mirror changes made before in the previous Quote app section (days/053-056).